Use window status style in window status format #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid overriding the colours defined in the style in the format. This fixes bug egel#12.
|
Hey @liovbt, thanks for the PR and your work. I will look at this after the release of v2.0.0, which I plan to do in short future. btw if interested you can also check it out. The monitor bell from #12 is definitely something that I want to fix. I am not actively using, although I hope I will be able to review your changes soon, learn from them, and apply the patch after v2. The most difficult part is testing for different terminals / OS. Of course now I've written some automatic tests for Linux (maybe I will also add for macOS) - but, they are mechanic, do not check DX. Before any release, it always crucial to me is to test organoleptically the changes if they work - unfortunately take the most time. Best, and see you around! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid overriding the colours defined in the style
in the format. This fixes bug #12.