Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: support node-v8.x #164

Merged
merged 2 commits into from
Jul 9, 2021
Merged

ci: support node-v8.x #164

merged 2 commits into from
Jul 9, 2021

Conversation

hyj1991
Copy link
Member

@hyj1991 hyj1991 commented Jul 9, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #164 (1c221f4) into master (29cb57d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #164   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          262       262           
  Branches         4         4           
=========================================
  Hits           262       262           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29cb57d...1c221f4. Read the comment docs.

@atian25
Copy link
Member

atian25 commented Jul 9, 2021

CI-OSX-8 / build 挂了

@hyj1991
Copy link
Member Author

hyj1991 commented Jul 9, 2021

CI-OSX-8 / build 挂了

image

这个其实还是那个在 CI 机器资源挤兑的情况下, egg-mock 启动的 app.ready() 后是否 http server 真的起来的问题导致的

@atian25 atian25 merged commit 0765c4c into master Jul 9, 2021
@atian25 atian25 deleted the support_v8.x branch July 9, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants