doc (README.md/README-zh_CN.md): Add clarification #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
========================================
+ Coverage 98.81% 100% +1.18%
========================================
Files 11 11
Lines 169 169
========================================
+ Hits 167 169 +2
+ Misses 2 0 -2
Continue to review full report at Codecov.
|
1) Due to `uws` isn't supported since Nodejs 10.x, so we should mention it by bolding the words to tell the users to avoid using `uws` directly in Nodejs 10.x or later version. 2) Change the uws's url, because this lib is duplicated, and we have to refer the npm url as the replacer.
ghost
deleted the
|
@ngot：In fact, consider old users using |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to
uwsisn't supported since Nodejs 10.x, so we should mentionit by bolding the words to tell the users to avoid using
uwsdirectlyin Nodejs 10.x or later version.
Change the uws's url, because this lib is duplicated, and we have to
refer the npm url as the replacer. The deprecated uws SHOUDN'T have
GitHub repository (See: https://www.npmjs.com/package/uws).
Ref：socketio/engine.io#560