-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ipc not work with worker_threads mode #5210
Conversation
@sjfkai 依赖可以升级到最新 2.0.0 版本 https://github.com/node-modules/sendmessage/actions/runs/5255496084 |
改了,帮忙跑一下 test 看看? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5210 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 36 36
Lines 3599 3603 +4
Branches 513 514 +1
=======================================
+ Hits 3594 3598 +4
Misses 5 5
☔ View full report in Codecov by Sentry. |
看了一下 test 报错。应该跟本次修改关系不大。 |
[skip ci] ## [3.16.1](v3.16.0...v3.16.1) (2023-06-15) ### Bug Fixes * ipc not work with worker_threads mode ([#5210](#5210)) ([03c8cf7](03c8cf7))
🎉 This PR is included in version 3.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
#5211 测试用例在这里修复 |
我之前也想这样做,但只是觉得不可思议……为啥必须要一个个而不是异步并行,是有什么文档说明吗? |
目前看起来不稳定,还没找到 root cause |
是的,我反复跑了几次,Windows上都可以通过,太奇怪了。 |
Checklist
npm test
passesAffected core subsystem(s)
lib/core/messenger
Description of change
Fix the issue where IPC does not work when startMode is set to 'worker_threads'.
This change depends on the modification made in "sendmessage #3". Please make sure that this change has taken effect before merging this one.