Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make plugins/development test stable #5211

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jun 15, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@fengmk2 fengmk2 force-pushed the make-test-stable branch from 59b9d9b to 031e977 Compare June 15, 2023 01:26
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (03c8cf7) 99.85% compared to head (031e977) 99.86%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5211    +/-   ##
========================================
  Coverage   99.85%   99.86%            
========================================
  Files          35       36     +1     
  Lines        3493     3603   +110     
  Branches      513      514     +1     
========================================
+ Hits         3488     3598   +110     
  Misses          5        5            

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@SEWeiTung SEWeiTung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice,but why should we use "await" here as MUST one? This only happens on non-Windows platform.

@SEWeiTung SEWeiTung merged commit c91ffe0 into master Jun 15, 2023
@SEWeiTung SEWeiTung deleted the make-test-stable branch June 15, 2023 10:00
SEWeiTung added a commit to SEWeiTung/egg that referenced this pull request Jun 15, 2023
fengmk2 pushed a commit that referenced this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants