docs: unify config in quickstart #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dead-horse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pmq20, @atian25 and @missjing to be potential reviewers. |
|
反了吧，应该统一改为 module.exports 的方式，这个才是大多数情况下会使用的格式。 |
|
quickstart 没有用到 appInfo，大部分情况也不会用到 appInfo，不要在这里引入 module.exports 形式的了，啰嗦还要解释什么是 appInfo |
|
quickstart 给出最简化的用法 |
|
之前最早就都是 exports 的，后面太多这方面的反馈了，不胜其烦，才改成 module 的。 想的是：看得懂的，看两个都一样；看不懂的，用插件的时候复制错了，就跑过来吐槽，烦。 |
|
既然都看不懂，就写简单的，再来问直接锁 issue |
Codecov Report
@@ Coverage Diff @@
## master #1094 +/- ##
======================================
Coverage 99.7% 99.7%
======================================
Files 29 29
Lines 676 676
======================================
Hits 674 674
Misses 2 2Continue to review full report at Codecov.
|
atian25
approved these changes
Jun 23, 2017
docs/source/en/intro/quickstart.md
Outdated
| }, | ||
| } | ||
| return config; | ||
| exports.keys = '<YOUR_SECURITY_COOKE_KEYS>'; |
docs/source/en/intro/quickstart.md
Outdated
| @@ -307,7 +301,7 @@ module.exports = app => { | |||
| And also add config. | |||
|
|
|||
| ```js | |||
| // config/config.default.js | |||
| // add news' configurations | |||
|
把脚手架改了吧 |
fengmk2
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
closes #1073