Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(app/extend/request.js): Some Comments from Chinese To English in union #2051

Merged
merged 2 commits into from Jan 29, 2018
Merged

style(app/extend/request.js): Some Comments from Chinese To English in union #2051

merged 2 commits into from Jan 29, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 29, 2018

Make some Chinese comments to English globally.
No functions changed

DongWei added 2 commits January 29, 2018 20:27
Make some Chinese comments to English globally
Because "No-Trailing spaces allowed for comments", which leads to a bad compilation, This should be fixed by removing the trailing spaces.
@codecov-io
Copy link

codecov-io commented Jan 29, 2018

Codecov Report

Merging #2051 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2051   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files          29       29           
  Lines         743      743           
=======================================
  Hits          740      740           
  Misses          3        3
Impacted Files Coverage Δ
app/extend/request.js 98.82% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e7710...a1590aa. Read the comment docs.

@ghost ghost changed the title [Update] Comments From Chinese to English docs(app/extend/request.js): Some Comments from Chinese To English in union Jan 29, 2018
@ghost ghost changed the title docs(app/extend/request.js): Some Comments from Chinese To English in union style(app/extend/request.js): Some Comments from Chinese To English in union Jan 29, 2018
@dead-horse dead-horse merged commit fa5bdae into eggjs:master Jan 29, 2018
popomore pushed a commit that referenced this pull request Jan 29, 2018
style(app/extend/request.js): Some Comments from Chinese To English in union (#2051)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants