Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update middleware.md #2069

Closed
wants to merge 1 commit into from
Closed

Update middleware.md #2069

wants to merge 1 commit into from

Conversation

x22x22
Copy link
Contributor

@x22x22 x22x22 commented Feb 1, 2018

middlewares是不是应该改成middleware?

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

middlewares是不是应该改成middleware?
@atian25
Copy link
Member

atian25 commented Feb 1, 2018

两个都可以的,印象中早期 app.middleware 是被 Koa 占用了的,后面好像搞定了。cc @popomore

@codecov-io
Copy link

codecov-io commented Feb 1, 2018

Codecov Report

Merging #2069 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2069   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files          29       29           
  Lines         743      743           
=======================================
  Hits          740      740           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1224dd6...a4ff112. Read the comment docs.

@x22x22
Copy link
Contributor Author

x22x22 commented Feb 1, 2018

那能在文档里说明一下吗?
因为用了typescript, 定义文件里没对middlewares属性进行描述, 这样乍一看还以为文档有问题.

@x22x22 x22x22 closed this Feb 1, 2018
@popomore
Copy link
Member

popomore commented Feb 1, 2018

搞定了,可以用 middleware 了

@atian25
Copy link
Member

atian25 commented Feb 1, 2018

@x22x22 提个 PR 吧,改为 app.middleware 吧,英文版也要改

@x22x22
Copy link
Contributor Author

x22x22 commented Feb 2, 2018

#2077
@atian25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants