docs(router): add definition of ctx #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please also change the en version, just push to this PR, don't reopen another. |
Codecov Report
@@ Coverage Diff @@
## master #2136 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 29 29
Lines 743 743
=======================================
Hits 740 740
Misses 3 3Continue to review full report at Codecov.
|
fengmk2
reviewed
Feb 26, 2018
| @@ -24,6 +24,7 @@ module.exports = app => { | |||
| // app/controller/user.js | |||
| class UserController extends Controller { | |||
| async info() { | |||
| const { ctx } = this; | |||
| this.ctx.body = { | |||
|
I'll handle this. https://github.com/eggjs/egg/pull/2144/files |
popomore
pushed a commit
that referenced
this pull request
Feb 28, 2018
docs(router): add definition of ctx (#2136)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change