Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add key any to Context #2650

Merged
merged 1 commit into from
Jun 5, 2018
Merged

fix: add key any to Context #2650

merged 1 commit into from
Jun 5, 2018

Conversation

whxaxes
Copy link
Member

@whxaxes whxaxes commented Jun 5, 2018

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

#2644

因为最近 koa 发的 typings 版本,在 Context 中将 [key: string]: any 去掉了,所以在我们这里补上。

在想 EggApplication 是否也需要加上 key any 参数,来保证至少不会抛编译错误?

@whxaxes whxaxes requested a review from shepherdwind June 5, 2018 10:45
@codecov
Copy link

codecov bot commented Jun 5, 2018

Codecov Report

Merging #2650 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2650   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          29       29           
  Lines         822      822           
=======================================
  Hits          819      819           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65a43aa...f6fee7f. Read the comment docs.

@atian25 atian25 merged commit e5737d5 into master Jun 5, 2018
@atian25 atian25 deleted the context-key-any branch June 5, 2018 12:06
popomore pushed a commit that referenced this pull request Jun 5, 2018
fix: add key any to Context (#2650)
@popomore popomore mentioned this pull request Jun 7, 2018
4 tasks
XadillaX pushed a commit to NBUT-Developers/egg that referenced this pull request Jun 7, 2018
XadillaX pushed a commit to NBUT-Developers/egg that referenced this pull request Jun 7, 2018
coolme200 pushed a commit that referenced this pull request Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants