Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(logger): add logger.disableConsoleAfterReady to docs #3384

Merged
merged 8 commits into from
Jan 17, 2019
Merged

docs(logger): add logger.disableConsoleAfterReady to docs #3384

merged 8 commits into from
Jan 17, 2019

Conversation

whxaxes
Copy link
Member

@whxaxes whxaxes commented Jan 9, 2019

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
  • 补充 logger.disableConsoleAfterReady 的文档

@whxaxes whxaxes requested review from atian25 and popomore January 9, 2019 06:51
@codecov
Copy link

codecov bot commented Jan 9, 2019 •
edited
Loading

Codecov Report

Merging #3384 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3384   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          29       29           
  Lines         844      844           
=======================================
  Hits          842      842           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271bc63...cfee44a. Read the comment docs.

@whxaxes whxaxes mentioned this pull request Jan 9, 2019
Closed
atian25
atian25 requested changes Jan 11, 2019
View reviewed changes
docs/source/en/core/logger.md Outdated Show resolved Hide resolved
docs/source/en/core/logger.md Outdated Show resolved Hide resolved
docs/source/en/core/logger.md Outdated Show resolved Hide resolved
docs/source/en/core/logger.md Outdated Show resolved Hide resolved
docs/source/zh-cn/core/logger.md Outdated Show resolved Hide resolved
@whxaxes
Copy link
Member Author

whxaxes commented Jan 16, 2019

@atian25 看下这个 PR 还有问题不，没就合了？

@whxaxes
Copy link
Member Author

whxaxes commented Jan 17, 2019

@atian25 approve 一下

@whxaxes whxaxes merged commit 8beacd1 into master Jan 17, 2019
@whxaxes whxaxes deleted the docs-logger-update branch January 17, 2019 13:02
popomore pushed a commit that referenced this pull request Jan 17, 2019
docs: auto generate by ci
190e53f 
docs(logger): add logger.disableConsoleAfterReady to docs (#3384)

* docs: update docs of logger.disableConsoleAfterReady
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atian25 atian25 atian25 requested changes

@dead-horse dead-horse dead-horse approved these changes

@popomore popomore Awaiting requested review from popomore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whxaxes @atian25 @dead-horse