fix: error message rewrite when it has only a getter #3796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gxcsoccer
reviewed
Jul 4, 2019
lib/application.js
Outdated
| } catch (_) { | ||
| // ignore, shouldjs will override error but missing setter. | ||
| // https://github.com/shouldjs/should.js/blob/889e22ebf19a06bc2747d24cf34b25cc00b37464/lib/assertion-error.js#L26 | ||
| } |
There was a problem hiding this comment.
const originMessage = err.message;
Object.defineProperty(this, "message", {
get: function() {
return originMessage + ' (uncaughtException throw ' + throwErrorCount + ' times on pid:' + process.pid + ')';
},
configurable: true,
enumerable: false
});There was a problem hiding this comment.
之前担心这样会影响到 shouldjs 的错误输出排版。
不过也可以吧，我改改
gxcsoccer
reviewed
Jul 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #3796 +/- ##
========================================
Coverage ? 100%
========================================
Files ? 34
Lines ? 943
Branches ? 0
========================================
Hits ? 943
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
atian25
force-pushed
the
compatibility-shouldjs
branch
from
1ab2047 to
ab63623
Compare
gxcsoccer
reviewed
Jul 4, 2019
| @@ -163,8 +163,17 @@ class Application extends EggApplication { | |||
| graceful({ | |||
| server: [ server ], | |||
| error: (err, throwErrorCount) => { | |||
| if (err.message) { | |||
| err.message += ' (uncaughtException throw ' + throwErrorCount + ' times on pid:' + process.pid + ')'; | |||
| const originMessage = err.message; | |||
There was a problem hiding this comment.
const originMessage = err.message || '';
atian25
changed the title
|
@atian25 ci 没过 |
atian25
force-pushed
the
compatibility-shouldjs
branch
from
ab63623 to
09d2016
Compare
atian25
force-pushed
the
compatibility-shouldjs
branch
from
09d2016 to
cd8f24b
Compare
popomore
pushed a commit
that referenced
this pull request
Jul 17, 2019
fix: error message rewrite when it has only a getter (#3796)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change