Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show warning message with call stack #549

Merged
merged 1 commit into from
Mar 11, 2017
Merged

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Mar 10, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

image

@mention-bot
Copy link

@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @popomore and @dead-horse to be potential reviewers.

@fengmk2 fengmk2 requested a review from popomore March 10, 2017 11:38
@fengmk2 fengmk2 force-pushed the show-dep-call-stack branch from a5677cf to 4c9ddfd Compare March 10, 2017 12:06
@codecov
Copy link

codecov bot commented Mar 10, 2017

Codecov Report

Merging #549 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #549   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          26     26           
  Lines         631    632    +1     
=====================================
+ Hits          631    632    +1
Impacted Files Coverage Δ
lib/agent.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a89c3b...4c9ddfd. Read the comment docs.

@dead-horse dead-horse merged commit d088283 into master Mar 11, 2017
@dead-horse dead-horse deleted the show-dep-call-stack branch March 11, 2017 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants