Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use mocha global hook to register before/after #140

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Jan 9, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@killagu killagu requested a review from fengmk2 January 9, 2023 02:42
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 86.14% // Head: 82.66% // Decreases project coverage by -3.48% ⚠️

Coverage data is based on head (4b0df65) compared to base (2134fc7).
Patch coverage: 85.41% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   86.14%   82.66%   -3.49%     
==========================================
  Files          23       25       +2     
  Lines        2317     2330      +13     
  Branches      388      378      -10     
==========================================
- Hits         1996     1926      -70     
- Misses        321      404      +83     
Impacted Files Coverage Δ
bootstrap.js 81.81% <0.00%> (-9.85%) ⬇️
lib/agent.js 72.22% <72.22%> (ø)
lib/parallel/agent_register.js 100.00% <100.00%> (ø)
register.js 100.00% <100.00%> (ø)
lib/parallel/agent.js 27.48% <0.00%> (-57.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

bootstrap.js Show resolved Hide resolved
@fengmk2 fengmk2 changed the title chore: use mocha global hook to register before/after feat: use mocha global hook to register before/after Jan 9, 2023
@fengmk2 fengmk2 merged commit 9ef65de into master Jan 9, 2023
@fengmk2 fengmk2 deleted the chore/mocha_hook branch January 9, 2023 06:43
atian25 pushed a commit that referenced this pull request Jan 9, 2023
[skip ci]

## [5.8.0](v5.7.1...v5.8.0) (2023-01-09)

### Features

* use mocha global hook to register before/after ([#140](#140)) ([9ef65de](9ef65de))
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

🎉 This PR is included in version 5.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants