fix: app should wait for agent ready on parallel mode #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 82.57% // Head: 82.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #144 +/- ##
==========================================
- Coverage 82.57% 82.11% -0.46%
==========================================
Files 25 25
Lines 2341 2371 +30
Branches 380 381 +1
==========================================
+ Hits 1933 1947 +14
- Misses 408 424 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fengmk2
commented
Jan 10, 2023
bootstrap.js
Outdated
| if (process.env.ENABLE_MOCHA_PARALLEL && process.env.AUTO_AGENT) { | ||
| // setup agent first | ||
| agent.setupAgent(); |
There was a problem hiding this comment.
这样也不对，按道理应该先执行 mochaGlobalSetup 才对的
fengmk2
commented
Jan 10, 2023
| beforeInit: async _app => { | ||
| const agent = await setupAgent(); | ||
| _app.options.clusterPort = agent.options.clusterPort; | ||
| debug('mockParallelApp beforeInit get clusterPort: %s', _app.options.clusterPort); |
There was a problem hiding this comment.
终于成功了，mocha global hook 有时序问题
fengmk2
changed the title
4 tasks
atian25
pushed a commit
that referenced
this pull request
Jan 11, 2023
[skip ci] ## [5.8.3](v5.8.2...v5.8.3) (2023-01-11) ### Bug Fixes * app should wait for agent ready on parallel mode ([#144](#144)) ([205e836](205e836))
|
🎉 This PR is included in version 5.8.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fengmk2
added a commit
to eggjs/bin
that referenced
this pull request
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change