fix: should support urls with controller string

[fengmk2]

Summary by CodeRabbit

• New Features

  • Enhanced routing functionality to handle arrays, strings, and regex inputs more effectively.

• Tests

  • Added a new test case to verify routing behavior for multiple URLs and controller strings.

[coderabbitai]

Walkthrough

The recent update enhances the Router class to handle arrays, strings, and regex input types more flexibly during routing. Additionally, it adds a new test case in EggRouter.test.ts to verify the correct routing behavior for multiple URLs with various HTTP verbs.

Changes

Files	Change Summary
src/Router.ts	Updated handling of array, string, and regex inputs in routing logic for Router class.
test/EggRouter.test.ts	Added a new test case to verify app.verb(urls, controllerString) for multiple HTTP verbs.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Router
    participant Controller

    Client->>Router: Sends request to multiple URLs
    Router->>Router: Process array, string, or regex input
    Router-->>Controller: Determine corresponding controller actions
    Controller-->>Router: Provides response for processing
    Router-->>Client: Respond with the appropriate action

Loading

Poem

In the code, we trim and tweak,
The router's paths are now unique.
Arrays and strings, regex too,
Routing paths are smooth, oh so new.
Tests ensure it's all just right,
EggRouter's routes, now clear and bright. 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (b5b5588) to head (65d42e6).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files           4        4           
  Lines        1710     1719    +9     
  Branches      224      227    +3     
=======================================
+ Hits         1696     1705    +9     
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a06ae6c and 65d42e6.

Files selected for processing (2)

• src/Router.ts (1 hunks)
• test/EggRouter.test.ts (1 hunks)

Additional context used

Biome

test/EggRouter.test.ts

[error] 39-39: This generator function doesn't contain yield. (lint/correctness/useYield)

---

[error] 282-282: This function expression can be turned into an arrow function. (lint/complexity/useArrowFunction)

Function expressions that don't use this can be turned into arrow functions.
Safe fix: Use an arrow function instead.

---

[error] 283-283: This function expression can be turned into an arrow function. (lint/complexity/useArrowFunction)

Function expressions that don't use this can be turned into arrow functions.
Safe fix: Use an arrow function instead.

---

[error] 284-284: This function expression can be turned into an arrow function. (lint/complexity/useArrowFunction)

Function expressions that don't use this can be turned into arrow functions.
Safe fix: Use an arrow function instead.

---

[error] 321-321: This function expression can be turned into an arrow function. (lint/complexity/useArrowFunction)

Function expressions that don't use this can be turned into arrow functions.
Safe fix: Use an arrow function instead.

src/Router.ts

[error] 316-319: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

---

[error] 334-337: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

---

[error] 305-305: Shouldn't redeclare 'allowedMethods'. Consider to delete it or rename it. (lint/suspicious/noRedeclare)

'allowedMethods' is defined here:

Additional comments not posted (2)

test/EggRouter.test.ts (1)

181-217: The test case for handling multiple URLs with a controller string is well-implemented. It thoroughly checks the registration and properties of the routes in the router stack. However, consider adding more detailed assertions for the controller's behavior to ensure that the controller string is resolved and executed correctly.

src/Router.ts (1)

622-630: The handling of array inputs and the setting of controller names have been enhanced to support more complex routing scenarios. This is a positive change for flexibility. Ensure that existing tests cover these new scenarios to prevent regressions.