chore(core/loader): use tegg-metadata EggLoadUnitType enum #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix(core/lifecycle): typo
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #176 +/- ##
=======================================
Coverage 92.52% 92.53%
=======================================
Files 235 235
Lines 5020 5021 +1
Branches 539 539
=======================================
+ Hits 4645 4646 +1
Misses 375 375 ☔ View full report in Codecov by Sentry. |
killagu
reviewed
Dec 13, 2023
| @@ -40,4 +40,4 @@ export class ModuleLoader implements Loader { | |||
| } | |||
| } | |||
|
|
|||
| LoaderFactory.registerLoader('MODULE', ModuleLoader.createModuleLoader); | |||
| LoaderFactory.registerLoader(EggLoadUnitType.MODULE, ModuleLoader.createModuleLoader); | |||
There was a problem hiding this comment.
@eggjs/tegg-metadata 这个需要从 devDep 挪到 dep 了。
There was a problem hiding this comment.
哦 没注意到这个 那看是否有必要了。
主要看到消费 createLoader 用了 enum
|
这需要从长计议一下了，目前 tegg 中容易引起 npm 的循环依赖，得做一下改造。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change