WIP: feat: add esm version #216

akitaSummer · 2024-04-19T21:58:43Z

Checklist

npm test passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

Description of change

coderabbitai · 2024-04-19T21:59:04Z

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

48 files out of 105 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

socket-security · 2024-04-19T21:59:46Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@eggjs/tegg-ajv-plugin@3.39.0	None	`+2`	201 kB	gxkl
npm/@eggjs/tegg-aop-plugin@3.39.0	Transitive: environment, eval, filesystem, network, unsafe	`+120`	21.1 MB	gxkl
npm/@eggjs/tegg-config@3.39.0	Transitive: environment, eval, filesystem	`+7`	928 kB	gxkl
npm/@eggjs/tegg-plugin@3.39.0	Transitive: environment, eval, filesystem, network, unsafe	`+125`	21.3 MB	gxkl
npm/egg-mock@5.10.9	environment, filesystem, network, shell Transitive: eval, unsafe	`+110`	5.07 MB	fengmk2
npm/egg-tracer@2.1.0	None	`0`	5.34 kB	fengmk2
npm/egg@3.22.0	filesystem, network, unsafe Transitive: environment, eval, shell	`+267`	17.1 MB	fengmk2

🚮 Removed packages: npm/@types/lodash@4.17.0, npm/@types/nunjucks@3.2.6

View full report↗︎

fengmk2 · 2024-04-20T03:04:57Z

core/ajv-decorator/tsconfig.esm.json

+  "extends": "../../tsconfig.json",
+  "compilerOptions": {
+    "moduleResolution": "Bundler",
+    "module": "ESNext",


ESNext 是代表 ES 的那个版本？

ESNext 是最新版本的，我先改成统一的使用ES2020吧

fengmk2 · 2024-04-20T03:05:50Z

是否需要加一个独立的集成测试，看看打包和独立运行 esm 版本是否正常？

killagu · 2024-04-22T06:28:42Z

core/ajv-decorator/esm/package.json

@@ -0,0 +1,3 @@
+{


这个文件要一直保留吗？能放到构建脚本生成吗？

killagu · 2024-04-22T06:29:50Z

core/ajv-decorator/tsconfig.esm.json

+  "extends": "../../tsconfig.json",
+  "compilerOptions": {
+    "moduleResolution": "node",
+    "module": "ESNext",


根路径下要不要搞个 tsconfig.esm.json?

我看每个文件夹下都有 tsconfig.pub.json ,为了保持一致我才添加了这个 config ，最好还是保持格式一致吧🤔

akitaSummer force-pushed the feat/standalone_esm branch from a105355 to 590f408 Compare April 19, 2024 22:00

fengmk2 reviewed Apr 20, 2024

View reviewed changes

akitaSummer force-pushed the feat/standalone_esm branch 2 times, most recently from 10fdb05 to 6e6bd90 Compare April 22, 2024 03:13

killagu reviewed Apr 22, 2024

View reviewed changes

akitaSummer force-pushed the feat/standalone_esm branch 2 times, most recently from 3036bc5 to 6710289 Compare April 22, 2024 12:40

feat: add esm version

933134c

akitaSummer force-pushed the feat/standalone_esm branch from 6710289 to 933134c Compare April 22, 2024 12:53

feat: add build script

31c1d87

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: feat: add esm version #216

WIP: feat: add esm version #216

akitaSummer commented Apr 19, 2024

coderabbitai bot commented Apr 19, 2024 •

edited

Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

socket-security bot commented Apr 19, 2024 •

edited

Loading

fengmk2 Apr 20, 2024

akitaSummer Apr 22, 2024

fengmk2 commented Apr 20, 2024

killagu Apr 22, 2024

akitaSummer Apr 22, 2024

killagu Apr 22, 2024

akitaSummer Apr 22, 2024

WIP: feat: add esm version #216

Are you sure you want to change the base?

WIP: feat: add esm version #216

Conversation

akitaSummer commented Apr 19, 2024

Checklist

Affected core subsystem(s)

Description of change

coderabbitai bot commented Apr 19, 2024 • edited Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

socket-security bot commented Apr 19, 2024 • edited Loading

fengmk2 Apr 20, 2024

Choose a reason for hiding this comment

akitaSummer Apr 22, 2024

Choose a reason for hiding this comment

fengmk2 commented Apr 20, 2024

killagu Apr 22, 2024

Choose a reason for hiding this comment

akitaSummer Apr 22, 2024

Choose a reason for hiding this comment

killagu Apr 22, 2024

Choose a reason for hiding this comment

akitaSummer Apr 22, 2024

Choose a reason for hiding this comment

coderabbitai bot commented Apr 19, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

socket-security bot commented Apr 19, 2024 •

edited

Loading