Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BinaryHeap #6

Closed
eggyal opened this issue Jan 10, 2023 · 2 comments
Closed

Add BinaryHeap #6

eggyal opened this issue Jan 10, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@eggyal
Copy link
Owner

eggyal commented Jan 10, 2023

No description provided.

@eggyal eggyal added the enhancement New feature or request label Jan 10, 2023
@eggyal
Copy link
Owner Author

eggyal commented Jan 10, 2023

Not entirely straightforward, since the subtree split/pull method currently employed to bring in the relevant bits of liballoc only works on git tree objects and not blobs—and liballoc's binary heap implementation is (currently) in a lone file within its collections subtree. Consequently, we'd either have to bring in the entire collections subtree (including other unwanted aspects such as VecDeque and LinkedList) or we must bring in the individual file through some other method (such as git fast-export/fast-import).

Perhaps liballoc can be persuaded to refactor for our benefit, but assuming not I will research how upstream changes to such a single file can be pulled in (if at all) and how to combine such an approach with the automated pulls for the rest of the imported pieces of liballoc that are being investigated as part of #2. At worst we can just import the whole collections subtree and ignore (or delete) those parts in which we're not interested.

@eggyal eggyal mentioned this issue Jan 10, 2023
Merged
JohnTitor pushed a commit to JohnTitor/rust that referenced this issue Jan 14, 2023
Rollup merge of rust-lang#106692 - eggyal:mv-binary_heap.rs-binary_he…
feac18c 
…ap/mod.rs, r=Mark-Simulacrum

mv binary_heap.rs binary_heap/mod.rs

I confess this request is somewhat selfish, as it's made in order to ease synchronisation with my [copse](https://crates.io/crates/copse) crate (see eggyal/copse#6 for explanation). I wholly understand that such grounds may be insufficient to justify merging this request—but no harm in asking, right?
@eggyal
Copy link
Owner Author

eggyal commented Jan 15, 2023

Fixed in a8aa2bc

@eggyal eggyal closed this as completed Jan 15, 2023
thomcc pushed a commit to tcdi/postgrestd that referenced this issue May 31, 2023
Rollup merge of #106692 - eggyal:mv-binary_heap.rs-binary_heap/mod.rs…
6280faf 
…, r=Mark-Simulacrum

mv binary_heap.rs binary_heap/mod.rs

I confess this request is somewhat selfish, as it's made in order to ease synchronisation with my [copse](https://crates.io/crates/copse) crate (see eggyal/copse#6 for explanation). I wholly understand that such grounds may be insufficient to justify merging this request—but no harm in asking, right?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eggyal