Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows path resolve, fix #42 #43

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

antfu
Copy link
Contributor

@antfu antfu commented May 2, 2024

Copy link

codesandbox bot commented May 2, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@egoist egoist merged commit d7ea404 into egoist:main May 2, 2024
3 checks passed
Copy link

github-actions bot commented May 2, 2024

🎉 This PR is included in version 4.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@timheerwagen
Copy link

This does not fix #43, because as stated before, the path ist marked as external by args.path.match(PATH_NODE_MODULES_RE) even if its the filepath when you try to bundle-require a file from node-modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants