This repository has been archived by the owner on Dec 6, 2021. It is now read-only.
Use URL of script instead of window.location for dev server #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you still maintaining 9.x? |
This was referenced Jun 2, 2018
|
@morrislaptop only bug fixes |
|
Is this a big or a feature?
On Sun, 3 Jun 2018 at 09:45, EGOIST ***@***.***> wrote:
@morrislaptop <https://github.com/morrislaptop> only bug fixes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#448 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAEI39Wl2BJ_7F0bUvrpg0Fct-ViiKMOks5t46IhgaJpZM4UXroV>
.
--
Craig Morris
+44 7903 900 116 | http://craigmorris.io |
http://uk.linkedin.com/in/morrislaptop | http://github.com/morrislaptop
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my scenario, the page is being served by PHP and the URL to the bundle is pointed directly to the webpack dev server.
So, the website is being served at http://my-project.test and the script is pointing to http://localhost:8080/app.js.
By using window.location for the webpack dev server client, it is forcing the sockjs server to be on the same domain as the page. However, it's more accurate to get the dev server from the script.
References: