Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruby 2.3 to travis #216

Merged
merged 1 commit into from
Jan 10, 2016
Merged

Conversation

waterlink
Copy link
Collaborator

No description provided.

@waterlink
Copy link
Collaborator Author

Ok, it is green, will squash it.

@waterlink
Copy link
Collaborator Author

The trick of installing ruby 2.3 on travis is to upgrade to trusty beta build. The downside is that ruby 1.8, 1.9.2 and jrubies can't be used yet for trusty build. Build matrix comes to the rescue in this PR.

@egonSchiele Can you take a look?

@egonSchiele
Copy link
Owner

lgtm @waterlink !

egonSchiele added a commit that referenced this pull request Jan 10, 2016
@egonSchiele egonSchiele merged commit 0905b57 into egonSchiele:master Jan 10, 2016
@waterlink waterlink deleted the add-ruby-2.3 branch January 24, 2016 15:40
@@ -1,13 +1,12 @@
dist: trusty
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it matter?
What is the default value? (with reference)

@PikachuEXE
Copy link
Collaborator

Oops forgot to read comments first :P
But I can put 2.3.0 without using trusty
Also surprisingly using alias does not always point to the latest patch level MRI
An example would be using 2.2 points to 2.2.0 not 2.2.4

@waterlink
Copy link
Collaborator Author

That happens because of --fuzzy option, that travis adds to the bundler
command

Best Regards,
Oleksii Fedorov,
Sr Ruby, Clojure, Crystal, Golang Developer,
Microservices Backend Engineer,
+49 15757 486 476

On Tue, Jan 26, 2016 at 3:19 AM, PikachuEXE notifications@github.com
wrote:

Oops forgot to read comments first :P
But I can put 2.3.0 without using trusty
fnando/i18n-js@d0e698e
Also surprisingly using alias does not always point to the latest patch
level MRI
An example would be using 2.2 points to 2.2.0 not 2.2.4
https://travis-ci.org/fnando/i18n-js/jobs/100535252


Reply to this email directly or view it on GitHub
#216 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants