Fixed issue where KeywordArgs is not checked if it is a hash. #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leads to issues when methods are overloaded, because when the KeywordArgs gets checked on a non-hash argument, it raises an exception rather than failing properly.
|
Thanks @dpad Could you please add this edge case to our test suite? |
|
For example in this spec file https://github.com/egonSchiele/contracts.ruby/blob/master/spec/ruby_version_specific/contracts_spec_2.0.rb |
|
Tests would be great. Thank you for the fix @dpad ! |
|
Added a test that fails without the fix, succeeds with. |
egonSchiele
added a commit
that referenced
this pull request
Mar 17, 2016
Fixed issue where KeywordArgs is not checked if it is a hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to issues when methods are overloaded, because when the
KeywordArgs gets checked on a non-hash argument, it raises an exception
rather than failing properly.