Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed serach popup issue #1162

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fixed serach popup issue #1162

merged 2 commits into from
Jul 26, 2024

Conversation

Swathi-eGov
Copy link
Contributor

No description provided.

Copy link
Collaborator

@jagankumar-egov jagankumar-egov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workbench package version to be incremented

Copy link
Contributor

coderabbitai bot commented Jul 26, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

Walkthrough

The recent updates enhance the micro-ui-internals package by introducing a new custom hook for search functionality, improving existing components, and refining documentation. Key changes include a new property in configuration files, optimized event handling in dropdowns, and an expanded ability to utilize custom hooks within the InboxSearchComposer. These adjustments improve usability, modularity, and clarity, providing users with a more robust interface for managing search operations.

Changes

File Change Summary
.../packages/modules/workbench/README.md Added entry for version 1.0.5 changelog indicating a fix for the search popup issue.
.../packages/modules/workbench/src/configs/searchMDMSConfigPopup.js Introduced customHook property in Config for improved configurability.
.../packages/modules/workbench/src/hooks/inbox.js Added useMDMSPopupSearch custom hook for data fetching with react-query.
.../packages/modules/workbench/src/hooks/index.js Enhanced Hooks structure with improved formatting and added inbox property for useMDMSPopupSearch.
.../packages/react-components/README.md Updated changelog for version 1.8.3 highlighting enhancements to Inboxsearchcomposer.
.../packages/react-components/src/atoms/Dropdown.js Modified "Enter" key handling in TextField to streamline selection when only one option is available.
.../packages/react-components/src/hoc/InboxSearchComposer.js Improved control flow to accommodate customHook, allowing more flexible hook utilization based on config.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant InboxSearchComposer
    participant CustomHook
    participant Config

    User->>InboxSearchComposer: Interacts with search
    InboxSearchComposer->>Config: Check for customHook
    alt Custom hook found
        InboxSearchComposer->>CustomHook: Execute useMDMSPopupSearch()
    else Default hook
        InboxSearchComposer->>DefaultAPI: Execute useCustomAPIHook()
    end
    CustomHook->>InboxSearchComposer: Return search results
    InboxSearchComposer-->>User: Display results
Loading

🐰 In the meadow where bunnies hop,
New hooks and features make my heart stop!
With dropdowns easier, and searches so bright,
I'm dancing with joy, oh what a delight!
Let's celebrate changes, both grand and small,
For a joyful interface brings happiness to all! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jagankumar-egov jagankumar-egov merged commit 5b9321d into master Jul 26, 2024
2 checks passed
@jagankumar-egov jagankumar-egov deleted the UCEM-510 branch July 26, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants