Greedy bottom up alternative based on egraph analysis algorithm #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi All,
This PR provides an alternative greedy bottom up extraction implementation --
BottomUpAnalysisExtractor
-- based on the egraph analysis algorithm that uses a pending queue. This is basically the algorithm that I use in my https://github.com/Bastacyclop/egg-sketches library.Based on #7
This is the (filtered) output of
make
:Overall we can see that the more complex
bottom-up-analysis
is slower on the easiest datasets 'babble' and 'egg', but also faster on the harder datasets 'flexc' and 'tensat'. I expectbottom-up-analysis
to perform even better on datasets with more costly to compute, child-dependent cost functions, although extraction-gym does not support such datasets yet.The dag costs also vary slightly due to different nodes being chosen -- I assume that the tree costs are the same but could double check.