Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite CALL/CALLARM64 relocations and add test for issue #87 #23

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

eh-steve
Copy link
Owner

@eh-steve eh-steve commented Sep 5, 2023

Can't seem to reproduce pkujhd#87

@eh-steve eh-steve requested a review from pkujhd September 5, 2023 10:28
@eh-steve eh-steve changed the title Add test for issue (#87)[https://github.com/pkujhd/goloader/issues/87] Add test for issue [#87](https://github.com/pkujhd/goloader/issues/87) Sep 5, 2023
@eh-steve eh-steve changed the title Add test for issue [#87](https://github.com/pkujhd/goloader/issues/87) Add test for issue #87 Sep 5, 2023
@pkujhd
Copy link
Collaborator

pkujhd commented Sep 6, 2023

Details

Maybe your branch get share memory in low-32bit. so it doesn't enter error branch

@eh-steve eh-steve force-pushed the issue-87 branch 3 times, most recently from c55452a to b041c77 Compare September 7, 2023 06:37
@eh-steve eh-steve changed the title Add test for issue #87 Rewrite CALL/CALLARM64 relocations and add test for issue #87 Sep 7, 2023
…en JMP (back from epilogue) instead of CALL (into epilogue) then JMP (into target func), since if a traceback hits while we're in the epilogue, the funcForPC for the current PC will not be aligned with the link register (regardless whether the LR is virtual or real), and it will appear that the callee and caller are the same `_func`
@eh-steve eh-steve merged commit 684a15f into master Dec 7, 2023
65 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants