-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster modulated pyramid wavefront sensor #162
Conversation
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 79.57% 80.99% +1.41%
==========================================
Files 94 95 +1
Lines 6503 6986 +483
==========================================
+ Hits 5175 5658 +483
Misses 1328 1328
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just simple style/docstring changes, plus one clarification.
I'll approve once the tests have passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This is the implementation of the faster modulated pwfs as mentioned in #112 . I have added a test to check the new method versus the old version and they agree quite well with each other. The maximum relative error is smaller than 2 percent, and the relative rms of the difference is ~0.2 percent.