Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster modulated pyramid wavefront sensor #162

Merged
merged 9 commits into from
Oct 25, 2022
Merged

Faster modulated pyramid wavefront sensor #162

merged 9 commits into from
Oct 25, 2022

Conversation

syhaffert
Copy link
Collaborator

This is the implementation of the faster modulated pwfs as mentioned in #112 . I have added a test to check the new method versus the old version and they agree quite well with each other. The maximum relative error is smaller than 2 percent, and the relative rms of the difference is ~0.2 percent.

@syhaffert syhaffert added the enhancement New feature or request label Oct 19, 2022
@syhaffert syhaffert added this to the v0.6.0 release milestone Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #162 (d08b5ef) into master (058c473) will increase coverage by 1.41%.
The diff coverage is 89.60%.

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   79.57%   80.99%   +1.41%     
==========================================
  Files          94       95       +1     
  Lines        6503     6986     +483     
==========================================
+ Hits         5175     5658     +483     
  Misses       1328     1328              
Impacted Files Coverage Δ
hcipy/aperture/__init__.py 100.00% <ø> (ø)
hcipy/optics/detector.py 72.46% <ø> (+0.82%) ⬆️
hcipy/plotting/field.py 80.00% <ø> (ø)
hcipy/optics/aberration.py 37.83% <50.00%> (ø)
hcipy/optics/fiber.py 67.30% <70.00%> (+2.13%) ⬆️
hcipy/coronagraphy/knife_edge.py 71.18% <71.42%> (+49.44%) ⬆️
hcipy/version.py 83.33% <81.81%> (+5.55%) ⬆️
hcipy/aperture/generic.py 89.43% <82.05%> (-3.23%) ⬇️
hcipy/field/coordinates.py 76.84% <92.85%> (+3.59%) ⬆️
hcipy/aperture/realistic.py 95.72% <94.16%> (-0.24%) ⬇️
... and 47 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@ehpor ehpor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just simple style/docstring changes, plus one clarification.

hcipy/wavefront_sensing/pyramid.py Show resolved Hide resolved
hcipy/wavefront_sensing/pyramid.py Outdated Show resolved Hide resolved
hcipy/wavefront_sensing/pyramid.py Outdated Show resolved Hide resolved
hcipy/wavefront_sensing/pyramid.py Show resolved Hide resolved
tests/test_wavefront_sensing.py Show resolved Hide resolved
hcipy/wavefront_sensing/pyramid.py Show resolved Hide resolved
tests/test_wavefront_sensing.py Show resolved Hide resolved
@ehpor
Copy link
Owner

ehpor commented Oct 25, 2022

I'll approve once the tests have passed.

Copy link
Owner

@ehpor ehpor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ehpor ehpor merged commit 38b6e89 into master Oct 25, 2022
@ehpor ehpor deleted the fast_pwfs branch October 25, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants