test: reduce max concurrent connections in check benchmarks (openfga#…

…2026)

pkg/server/test/check.go

@@ -19,6 +19,9 @@ import (
 	"github.com/openfga/openfga/pkg/typesystem"
 )
 
+// to prevent overwhelming server on expensive queries.
+const maxConcurrentReads = 50
+
 // Some of the benchmark tests require context blocks to be built
 // but many do not. This noop method is a placeholder for the non-context test cases.
 func noopContextGenerator() *structpb.Struct {
@@ -382,9 +385,9 @@ func BenchmarkCheck(b *testing.B, ds storage.OpenFGADatastore) {
 
 		checkQuery := commands.NewCheckCommand(
 			ds,
-			graph.NewLocalChecker(),
+			graph.NewLocalChecker(graph.WithOptimizations(true)),
 			typeSystem,
-			commands.WithCheckCommandMaxConcurrentReads(config.DefaultMaxConcurrentReadsForCheck),
+			commands.WithCheckCommandMaxConcurrentReads(maxConcurrentReads),
 			commands.WithCheckCommandResolveNodeLimit(config.DefaultResolveNodeLimit),
 		)
 
@@ -396,8 +399,8 @@ func BenchmarkCheck(b *testing.B, ds storage.OpenFGADatastore) {
 					Context:  bm.contextGenerator(),
 				})
 
-				require.Equal(b, bm.expected, response.GetAllowed())
 				require.NoError(b, err)
+				require.Equal(b, bm.expected, response.GetAllowed())
 			}
 		})
 	}
@@ -475,9 +478,9 @@ func benchmarkCheckWithBypassUsersetReads(b *testing.B, ds storage.OpenFGADatast
 
 	checkQuery := commands.NewCheckCommand(
 		ds,
-		graph.NewLocalChecker(),
+		graph.NewLocalChecker(graph.WithOptimizations(true)),
 		typeSystemTwo,
-		commands.WithCheckCommandMaxConcurrentReads(config.DefaultMaxConcurrentReadsForCheck),
+		commands.WithCheckCommandMaxConcurrentReads(maxConcurrentReads),
 		commands.WithCheckCommandResolveNodeLimit(config.DefaultResolveNodeLimit),
 	)
 
@@ -488,8 +491,8 @@ func benchmarkCheckWithBypassUsersetReads(b *testing.B, ds storage.OpenFGADatast
 				TupleKey: tuple.NewCheckRequestTupleKey("document:budget", "viewer", "user:anne"),
 			})
 
-			require.False(b, response.GetAllowed())
 			require.NoError(b, err)
+			require.False(b, response.GetAllowed())
 		}
 	})
 }