Variables, added locks & fixed two_to_three #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change variable names & added locks to prevent the issue you described
|
Yes, you are correct. I first intended to use unique and then SQL didn't like it for obvious reasons. Thanks for the Locks that's really neat. This evening I will add the system notifications checks for the db.notify functions since I forgot to add them. |
eibex
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the variable names in wait_for, fixed the issue you mentioned by adding locks and fixed two_to_three (you had written unique instead of limit_to_one, unique should never be in that list if I've understood the changes correctly. Ran in to an issue when running a test)