i18n #77
i18n #77
Conversation
| except KeyError: | ||
| response = self.responses["en"][item] | ||
| print(f"Could not find a translation ({self.language}) for the requested i18n item: {item}. Please file an issue on GitHub.") | ||
| response = response.replace("{prefix}", self.prefix) |
There was a problem hiding this comment.
Feels like this should be handled in the .format elsewhere, seems odd to only handle this replacement here.
There was a problem hiding this comment.
I did it like this because it's the only var that is fixed and present across several strings.
There was a problem hiding this comment.
Wouldn't it feel redundant to .format(prefix) everywhere?
There was a problem hiding this comment.
True, although I don't like the concept of one variable being handled differently from the others, might get confusing down the line
There was a problem hiding this comment.
Yeah, I can see your point too.
I will leave this unresolved for now while I think about it.
Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
|
Ready for review, working on a translation and the fairly simple rl!language command. |
Implement i18n module for easy l10n with json files.
Closes #74