Skip to content

Commit

Permalink
Updated LFHCAL ADC parameters and threshold (#1105)
Browse files Browse the repository at this point in the history
### Briefly, what does this PR introduce?
Updated LFHCAL ADC params from the [digitization table from
10/2](https://brookhavenlab.sharepoint.com/:x:/s/EICPublicSharingDocs/EeICxMJ9vGtPtyq5g4qzcSwBKCqkHDj06KDdSvYQ7pxqrQ?rtime=lD_5kMnT20g).

Threshold on the ADC level:
0.3 MeV deposition --> adc = 50 + 0.3 / 1000 * 65536 == 70 -->
thresholdValue = 20


### What kind of change does this PR introduce?
- [x] Bug fix (issue #895 )
- [ ] New feature (issue #__)
- [ ] Documentation update
- [x] Other: Maintenance

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
Yes.
  • Loading branch information
kkauder committed Nov 11, 2023
1 parent b5bcd65 commit c4db9e2
Showing 1 changed file with 19 additions and 12 deletions.
31 changes: 19 additions & 12 deletions src/detectors/FHCAL/FHCAL.cc
Original file line number Diff line number Diff line change
Expand Up @@ -125,17 +125,24 @@ extern "C" {
)
);

// Make sure digi and reco use the same value
decltype(CalorimeterHitDigiConfig::capADC) LFHCAL_capADC = 65536;
decltype(CalorimeterHitDigiConfig::dyRangeADC) LFHCAL_dyRangeADC = 1 * dd4hep::GeV;
decltype(CalorimeterHitDigiConfig::pedMeanADC) LFHCAL_pedMeanADC = 50;
decltype(CalorimeterHitDigiConfig::pedSigmaADC) LFHCAL_pedSigmaADC = 10;
decltype(CalorimeterHitDigiConfig::resolutionTDC) LFHCAL_resolutionTDC = 10 * dd4hep::picosecond;

app->Add(new JChainMultifactoryGeneratorT<CalorimeterHitDigi_factoryT>(
"LFHCALRawHits", {"LFHCALHits"}, {"LFHCALRawHits"},
{
.eRes = {},
.tRes = 0.0 * dd4hep::ns,
.capADC = 65536,
.capADC = LFHCAL_capADC,
.capTime = 100,
.dyRangeADC = 1 * dd4hep::GeV,
.pedMeanADC = 20,
.pedSigmaADC = 0.8,
.resolutionTDC = 10 * dd4hep::picosecond,
.dyRangeADC = LFHCAL_dyRangeADC,
.pedMeanADC = LFHCAL_pedMeanADC,
.pedSigmaADC = LFHCAL_pedSigmaADC,
.resolutionTDC = LFHCAL_resolutionTDC,
.corrMeanScale = 1.0,
.readout = "LFHCALHits",
.fields = {"layerz"},
Expand All @@ -145,13 +152,13 @@ extern "C" {
app->Add(new JChainMultifactoryGeneratorT<CalorimeterHitReco_factoryT>(
"LFHCALRecHits", {"LFHCALRawHits"}, {"LFHCALRecHits"},
{
.capADC = 65536,
.dyRangeADC = 1 * dd4hep::GeV,
.pedMeanADC = 20,
.pedSigmaADC = 0.8,
.resolutionTDC = 10 * dd4hep::picosecond,
.thresholdFactor = 1.0,
.thresholdValue = 3.0,
.capADC = LFHCAL_capADC,
.dyRangeADC = LFHCAL_dyRangeADC,
.pedMeanADC = LFHCAL_pedMeanADC,
.pedSigmaADC = LFHCAL_pedSigmaADC,
.resolutionTDC = LFHCAL_resolutionTDC,
.thresholdFactor = 0.0,
.thresholdValue = 20, // 0.3 MeV deposition --> adc = 50 + 0.3 / 1000 * 65536 == 70
.sampFrac = 0.033,
.sampFracLayer = {
0.019, // 0
Expand Down

0 comments on commit c4db9e2

Please sign in to comment.