Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An exception in factory Init() should cause termination with an error exit code #625

Open
veprbl opened this issue Apr 21, 2023 · 1 comment · May be fixed by #1069
Open

An exception in factory Init() should cause termination with an error exit code #625

veprbl opened this issue Apr 21, 2023 · 1 comment · May be fixed by #1069
Assignees

Comments

@veprbl
Copy link
Member

veprbl commented Apr 21, 2023

Expected Result: (what do you expect when you execute the steps above)

Reconstruction terminates

Actual Result: (what do you get when you execute the steps above)

[2023-04-21 18:24:45.464] [JEventProcessorPODIO] [error] Omitting PODIO collection 'FooBarFactory' due to exception: Unknown exception in JFactoryT::Init().

and reconstruction continues

@nathanwbrei
Copy link
Contributor

nathanwbrei commented Apr 24, 2023

I fully agree that we should remove the try/catch block inside JEventProcessorPODIO and let crashing factories crash rather than attempting to keep going. Most of the crashing factories are excepting because there is a JEvent::Get() for some T that is not present in the input file (due to geometry, etc). We can use the non-excepting forms of Get/GetSingle, or we can wrap them in the try/catch block instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants