-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Dmitry R.'s platform #637
Conversation
for more information, see https://pre-commit.ci
Can we review these changes in separate PRs? Some are not uncontroversial. |
Absolutely! I fully expect this us to cherry pick and/or drop some of these commits. The important thing is that we all see what the changes are, and more or less agree on which should make it into master. When it comes to specifics:
|
### Briefly, what does this PR introduce? Single commit from #637. Allegedly already approved by experts. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? ### Does this PR change default behavior? Co-authored-by: Dmitry Romanov <romanovda@gmail.com>
@nathanwbrei @veprbl @DraTeots Can this be closed? |
I didn't see useful changes that weren't yet ported. |
Briefly, what does this PR introduce?
@DraTeots helped me quite a bit with PR #578. He made a lot of small fixes in order to get EICrecon to build on his system. For the sake of keeping the huge PR as manageable as possible, I didn't include these in the final PR. Rather than throw this work away, however, I cherry-picked the changes that didn't make it into main so that we can have a look at them and decide what to keep.
Probably the most important fix in here is an issue with Eigen alignments.
The changes related to exception handling are going to inform my response to issue #625.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?