Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install capybara only when not available #1110

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

Instead of installing epic-capybara for every pipeline, this only installs when capybara is not already in the path.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

.github/workflows/linux-eic-shell.yml Outdated Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Outdated Show resolved Hide resolved
@wdconinc wdconinc force-pushed the use-capybara-if-already-available branch from 8c597a4 to 7816ae7 Compare January 4, 2024 21:10
@wdconinc wdconinc requested a review from veprbl January 4, 2024 21:11
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is long overdue.

@veprbl veprbl enabled auto-merge January 4, 2024 21:20
@veprbl veprbl added this pull request to the merge queue Jan 4, 2024
Merged via the queue into main with commit 7c284a6 Jan 4, 2024
71 checks passed
@veprbl veprbl deleted the use-capybara-if-already-available branch January 4, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants