Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): produce PR and capybara summary; print to step summary #1122

Merged
merged 7 commits into from
Nov 21, 2023

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This aims to present the capybara results in a more accessible way, by integrating them in the browsable structure at eicrecon.epic-eic.org, and by printing them as a step summary in the github actions summary interface.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@github-actions github-actions bot added the topic: documentation Improvements or additions to documentation label Nov 17, 2023
.github/workflows/linux-eic-shell.yml Outdated Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Outdated Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Outdated Show resolved Hide resolved
@wdconinc wdconinc force-pushed the capybara-step-summary branch from 81f0c14 to b56f299 Compare November 18, 2023 04:05
@wdconinc wdconinc marked this pull request as ready for review November 18, 2023 13:52
@wdconinc wdconinc requested a review from veprbl November 18, 2023 13:54
@wdconinc wdconinc enabled auto-merge November 18, 2023 14:22
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wdconinc wdconinc added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit c606b78 Nov 21, 2023
74 checks passed
@wdconinc wdconinc deleted the capybara-step-summary branch November 21, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Improvements or additions to documentation topic: infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants