fix(ci): don't upload unused build directory artifacts #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
commented
Nov 18, 2023
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Ready for review. Does what it's intended to do: not upload useless things; speed up pipelines. |
wdconinc
force-pushed
the
clang-tidy-iwyu-build-artifact
branch
from
ae79bc8 to
4a3a974
Compare
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
wdconinc
force-pushed
the
clang-tidy-iwyu-build-artifact
branch
from
4a3a974 to
aa7e68e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
We spend several minutes just waiting for the build artifacts to get uploaded, and then we don't use them... This only uploads the build directory artifact that is used by the clang-tidy-iwyu job (which is, incidentally, associated with the fasted compilation job, the smallest build directory, and fastest upload). This will speed up when the build matrix completes, and when the next set of jobs can start running.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.