Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): run at least compilation and unit tests on few fixed jug_xl #1136

Merged
merged 24 commits into from
Apr 26, 2024

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This changes the CI philosophy to run the compilation and unit testing on an expanded set of platform versions. It does this for the clang release versions, since fastest. It separates the default CI platform (set as input on workflow_dispatch) from the explicit platform versions sets in the build job matrix (there may be overlap, even by default).

What kind of change does this PR introduce?

  • Bug fix (issue: need to test on more versions/platforms; have tests on stable platform by default)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc
Copy link
Contributor Author

The idea here would be for the default platform in the workflow_dispatch to point to the oldest tested environment (e.g. right now jug_xl:23.12-alpha) with at least the liatest tested environment (jug_xl:nightly) included in the build job matrix.

@wdconinc wdconinc force-pushed the test-on-jug-xl-nightly-and-23.12-alpha branch 2 times, most recently from 69ac9bd to 74d6b70 Compare January 4, 2024 21:40
.github/workflows/linux-eic-shell.yml Outdated Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Outdated Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Outdated Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Outdated Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Outdated Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Outdated Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Outdated Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Outdated Show resolved Hide resolved
.github/workflows/linux-eic-shell.yml Outdated Show resolved Hide resolved
@wdconinc wdconinc requested a review from veprbl January 5, 2024 16:47
@wdconinc
Copy link
Contributor Author

wdconinc commented Jan 5, 2024

@veprbl This now runs at least compilation and unit tests on jug_xl:23.12-alpha in addition to the usual nightly. It's not quite a full systems test, but I think most regressions would be of the kind that lead to failed compilation, not regressions that still compile fine and pass unit tests but somehow don't run beyond that.

@wdconinc wdconinc enabled auto-merge January 5, 2024 16:49
@wdconinc
Copy link
Contributor Author

wdconinc commented Jan 5, 2024

"API rate limit exceeded" and it is not recognizing the renamed jobs of course. If approved, I'll go ahead and change the branch protection settings to use the new names.

@wdconinc wdconinc force-pushed the test-on-jug-xl-nightly-and-23.12-alpha branch from 77306d0 to ce80ffd Compare January 12, 2024 15:57
@wdconinc wdconinc force-pushed the test-on-jug-xl-nightly-and-23.12-alpha branch from ce80ffd to b76b917 Compare January 12, 2024 18:44
@wdconinc wdconinc force-pushed the test-on-jug-xl-nightly-and-23.12-alpha branch from b76b917 to 08d9388 Compare January 31, 2024 17:36
@wdconinc wdconinc force-pushed the test-on-jug-xl-nightly-and-23.12-alpha branch from 08d9388 to 2ed7ed6 Compare February 27, 2024 00:34
@wdconinc wdconinc force-pushed the test-on-jug-xl-nightly-and-23.12-alpha branch from 2ed7ed6 to dfd6635 Compare April 17, 2024 12:31
@wdconinc wdconinc force-pushed the test-on-jug-xl-nightly-and-23.12-alpha branch from bcd3e5e to d5d2e67 Compare April 26, 2024 00:00
@wdconinc wdconinc enabled auto-merge April 26, 2024 00:00
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good

@wdconinc wdconinc added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit f22c252 Apr 26, 2024
81 checks passed
@wdconinc wdconinc deleted the test-on-jug-xl-nightly-and-23.12-alpha branch April 26, 2024 19:08
ajentsch pushed a commit that referenced this pull request May 20, 2024
…1136)

### Briefly, what does this PR introduce?
This changes the CI philosophy to run the compilation and unit testing
on an expanded set of platform versions. It does this for the clang
release versions, since fastest. It separates the default CI platform
(set as input on workflow_dispatch) from the explicit platform versions
sets in the build job matrix (there may be overlap, even by default).

### What kind of change does this PR introduce?
- [x] Bug fix (issue: need to test on more versions/platforms; have
tests on stable platform by default)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.

---------

Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants