fix: move remaining JChainFactory algorithms to JChainMultifactory #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
force-pushed
the
JChainFactoryT-to-JChainMultiFactoryT
branch
3 times, most recently
from
c0f381c to
1d180dd
Compare
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Many diffs now, https://github.com/eic/EICrecon/actions/runs/7024406714/job/19113472906?pr=1142, but includes timestamp changes and may be due to rollout of recent geometry changes, in particular eic/epic@0746c07. (we need checksum comparisons) |
wdconinc
force-pushed
the
JChainFactoryT-to-JChainMultiFactoryT
branch
from
3365f8a to
e3a5213
Compare
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
wdconinc
force-pushed
the
JChainFactoryT-to-JChainMultiFactoryT
branch
from
e3a5213 to
a40f43b
Compare
wdconinc
force-pushed
the
JChainFactoryT-to-JChainMultiFactoryT
branch
from
a40f43b to
0d2babd
Compare
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Much better. No more diffs https://github.com/eic/EICrecon/actions/runs/7040539144/job/19162385780#step:11:105. |
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
I'll go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
We still had a number of algorithms inheriting JChainFactory, not JChainMultifactory. This migrates these remaining ones to JChainMultifactory.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.