Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): compress install and build artifact with zstd #1152

Merged
merged 3 commits into from
Nov 25, 2023

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Nov 25, 2023

Briefly, what does this PR introduce?

After finding in #1124 that compression does matter, we might as well use the best modern compression currently available to evaluate if it does any better than gz. Since it does (comment below) we apply this to both install and build artifacts.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc wdconinc force-pushed the tar-build-artifact-zstd branch from 1c312c2 to 962c7fe Compare November 25, 2023 17:12
@wdconinc wdconinc changed the title fix(ci): compress build artifact with zstd fix(ci): compress install and build artifact with zstd Nov 25, 2023
@wdconinc
Copy link
Contributor Author

Zstd compression of install artifact too

https://github.com/eic/EICrecon/actions/runs/6990412286/job/19019903373
Screenshot_20231125-115714

@wdconinc wdconinc added this pull request to the merge queue Nov 25, 2023
Merged via the queue into main with commit 3ef2061 Nov 25, 2023
67 checks passed
@wdconinc wdconinc deleted the tar-build-artifact-zstd branch November 25, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants