fix: convert TrackParamTruthInit to use DD4hep units #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
commented
Jan 2, 2024
wdconinc
commented
Jan 4, 2024
wdconinc
force-pushed
the
1166-trackparamtruthinitconfig-assumes-acts-unit-system
branch
from
f730f4d to
db4a59e
Compare
wdconinc
commented
Jan 8, 2024
wdconinc
force-pushed
the
1166-trackparamtruthinitconfig-assumes-acts-unit-system
branch
from
e45de40 to
ce75dfc
Compare
wdconinc
force-pushed
the
1166-trackparamtruthinitconfig-assumes-acts-unit-system
branch
from
ce75dfc to
cb4d891
Compare
wdconinc
commented
Jan 12, 2024
|
No diffs. |
Is that with running capybara locally? |
|
Might be that webpages are out of sync. Last CI run eg https://github.com/eic/EICrecon/actions/runs/7503697056/job/20430403477 has no diffs. |
veprbl
approved these changes
Jan 12, 2024
|
Definitely we should move to |
wdconinc
deleted the
1166-trackparamtruthinitconfig-assumes-acts-unit-system
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Units are set (via command line or config files) assuming a certain unit system. We have chosen DD4hep for this in all other cases (in part because it comes with a parser). Having one algorithm use Acts units is potentially confusing since distances may be passed in the wrong units.
This PR converts TrackParamTruthInit to store the config variables in DD4hep units, and modifies the algorithm itself to interpret the config in DD4hep units. No changes are expected to the output.
No values are specified in the factory or in the plugin, so this is the only change that should be needed.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.