feat: replace draw_surfaces with Acts-based obj and ply export #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: tracking
Capybara summary for PR 1357 |
|
This is probably going to look mostly like modern art, but here is what all these layers look like in meshlab (default color assignments, meshes as downloaded from CI):
|
mposik1983
approved these changes
Apr 2, 2024
|
I will go ahead and merge this already. The reason why this is exported for each DIS test sample (even though this only depends on geometry currently) is because I am working on exports of event data as well (covariance ellipses for measurements, etc), see https://acts.readthedocs.io/en/latest/core/visualization/3d.html. That's likely something that should be done in a next PR. |
ajentsch
pushed a commit
that referenced
this pull request
May 20, 2024
### Briefly, what does this PR introduce? Instead of writing our own obj files in `draw_surfaces` (with only support for planar surfaces), this PR converts it to use the Acts support for export to obj and ply files, optionally and with parameter support for coloring etc. Syntax is: ``` eicrecon -Pacts:WriteObj=true -Pacts:WritePly=true -Pacts:OutputDir=$PWD/tracking_geometry ``` where `OutputDir` must exist and defaults to current working directory (because it exists; upstream choice). To open the obj and ply models, you can use e.g. [meshlab](https://www.meshlab.net). Just import all files at once. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #1330) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? Yes, by default `tracking_geometry.obj` will not be written anymore. --------- Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Instead of writing our own obj files in
draw_surfaces(with only support for planar surfaces), this PR converts it to use the Acts support for export to obj and ply files, optionally and with parameter support for coloring etc. Syntax is:where
OutputDirmust exist and defaults to current working directory (because it exists; upstream choice).To open the obj and ply models, you can use e.g. meshlab. Just import all files at once.
What kind of change does this PR introduce?
draw_surfaces#1330)Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
Yes, by default
tracking_geometry.objwill not be written anymore.