Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): run cmake-format in ci #1372

Merged
merged 3 commits into from
Apr 10, 2024
Merged

feat(ci): run cmake-format in ci #1372

merged 3 commits into from
Apr 10, 2024

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Apr 8, 2024

Briefly, what does this PR introduce?

We don't let the CI pre-commit job run automatic clang-format and cmake-format fixes. This PR changes that behavior for cmake-format.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators @veprbl

Does this PR introduce breaking changes? What changes might users need to make to their code?

No changes.

Does this PR change default behavior?

Yes, it might lead to developers seeing their code reformatted automatically.

@github-actions github-actions bot added topic: calorimetry relates to calorimetry topic: tracking Relates to tracking reconstruction topic: PID Relates to PID reconstruction topic: far-forward Far forward reconstruction topic: far-backward Reconstruction related to far backward detectors topic: infrastructure topic: barrel topic: forward topic: backward topic: digitization labels Apr 8, 2024
@wdconinc wdconinc changed the title feat(ci): run clang-format and cmake-format in ci feat(ci): run cmake-format in ci Apr 8, 2024
@wdconinc wdconinc requested a review from veprbl April 8, 2024 23:28
@wdconinc wdconinc force-pushed the ci-clang-cmake-format branch from 7d62e7e to 48d4e46 Compare April 10, 2024 02:04
@wdconinc wdconinc enabled auto-merge April 10, 2024 02:04
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@wdconinc wdconinc added this pull request to the merge queue Apr 10, 2024
Merged via the queue into main with commit 5f2afbb Apr 10, 2024
74 of 75 checks passed
@wdconinc wdconinc deleted the ci-clang-cmake-format branch April 10, 2024 23:55
ajentsch pushed a commit that referenced this pull request May 20, 2024
We don't let the CI pre-commit job run automatic clang-format and
cmake-format fixes. This PR changes that behavior for cmake-format.

- [ ] Bug fix (issue #__)
- [x] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators @veprbl

need to make to their code?
No changes.

Yes, it might lead to developers seeing their code reformatted
automatically.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: backward topic: barrel topic: calorimetry relates to calorimetry topic: digitization topic: far-backward Reconstruction related to far backward detectors topic: far-forward Far forward reconstruction topic: forward topic: infrastructure topic: PID Relates to PID reconstruction topic: tracking Relates to tracking reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants