-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): run cmake-format in ci #1372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: calorimetry
relates to calorimetry
topic: tracking
Relates to tracking reconstruction
topic: PID
Relates to PID reconstruction
topic: far-forward
Far forward reconstruction
topic: far-backward
Reconstruction related to far backward detectors
topic: infrastructure
topic: barrel
topic: forward
topic: backward
topic: digitization
labels
Apr 8, 2024
wdconinc
changed the title
feat(ci): run clang-format and cmake-format in ci
feat(ci): run cmake-format in ci
Apr 8, 2024
Capybara summary for PR 1372 |
wdconinc
force-pushed
the
ci-clang-cmake-format
branch
from
April 10, 2024 02:04
7d62e7e
to
48d4e46
Compare
veprbl
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it
ajentsch
pushed a commit
that referenced
this pull request
May 20, 2024
We don't let the CI pre-commit job run automatic clang-format and cmake-format fixes. This PR changes that behavior for cmake-format. - [ ] Bug fix (issue #__) - [x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators @veprbl need to make to their code? No changes. Yes, it might lead to developers seeing their code reformatted automatically. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: backward
topic: barrel
topic: calorimetry
relates to calorimetry
topic: digitization
topic: far-backward
Reconstruction related to far backward detectors
topic: far-forward
Far forward reconstruction
topic: forward
topic: infrastructure
topic: PID
Relates to PID reconstruction
topic: tracking
Relates to tracking reconstruction
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
We don't let the CI pre-commit job run automatic clang-format and cmake-format fixes. This PR changes that behavior for cmake-format.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No changes.
Does this PR change default behavior?
Yes, it might lead to developers seeing their code reformatted automatically.