Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FarDetectorTrackerCluster.cc: ulong -> unsigned long #1413

Merged
merged 1 commit into from
May 4, 2024
Merged

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented May 4, 2024

ulong from sys/types is not a standard C type

This fixes a compilation error:

src/algorithms/fardetectors/FarDetectorTrackerCluster.cc:113:26: error: use of undeclared identifier 'ulong'; did you mean 'long'?
      ROOT::VecOps::RVec<ulong> clusterList = {maxIndex};
                         ^~~~~
                         long

ulong from sys/types is not a standard C type
@veprbl veprbl requested a review from simonge May 4, 2024 15:12
Copy link
Contributor

@simonge simonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this being silently flagged in any tests?

@veprbl
Copy link
Member Author

veprbl commented May 4, 2024

No, actually this is from a private build on macOS. IIRC the GNU libc headers allow ulong and such by default, and sys/types gets included somewhere along the way.

@veprbl veprbl added this pull request to the merge queue May 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 4, 2024
@veprbl veprbl added this pull request to the merge queue May 4, 2024
Merged via the queue into main with commit 4c8b36f May 4, 2024
85 of 87 checks passed
@veprbl veprbl deleted the pr/no_ulong branch May 4, 2024 17:35
ajentsch pushed a commit that referenced this pull request May 20, 2024
ulong from sys/types is not a standard C type

This fixes a compilation error:
```
src/algorithms/fardetectors/FarDetectorTrackerCluster.cc:113:26: error: use of undeclared identifier 'ulong'; did you mean 'long'?
      ROOT::VecOps::RVec<ulong> clusterList = {maxIndex};
                         ^~~~~
                         long
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants