Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-eic-shell.yml: specify clang++ explicitly #1422

Merged
merged 4 commits into from
Jun 13, 2024
Merged

linux-eic-shell.yml: specify clang++ explicitly #1422

merged 4 commits into from
Jun 13, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented May 6, 2024

/usr/bin/c++ --version
c++ (Debian 12.2.0-14) 12.2.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

```
/usr/bin/c++ --version
c++ (Debian 12.2.0-14) 12.2.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
```
@veprbl veprbl temporarily deployed to github-pages May 12, 2024 01:07 — with GitHub Actions Inactive
@wdconinc
Copy link
Contributor

wdconinc commented Jun 4, 2024

The current behavior here is explained in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#expanding-or-adding-matrix-configurations. Later definitions apply to all earlier definitions that match without overwrites, and create a new entry if there is no match. Since we define a clang/clang++ combo earlier, simply using clang refers to this. The proposed changes don't hurt, though, and may be better for clarity.

@veprbl veprbl enabled auto-merge June 5, 2024 20:55
@veprbl veprbl temporarily deployed to github-pages June 6, 2024 01:03 — with GitHub Actions Inactive
@veprbl veprbl added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit e4e5b01 Jun 13, 2024
83 of 84 checks passed
@veprbl veprbl deleted the pr/clangxx_set branch June 13, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants