Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): add matrix.release to ccache key #1425

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented May 7, 2024

Briefly, what does this PR introduce?

This PR adds the release environment name to the ccache key to ensure that eic_xl:nightly and eic_xl:24.04.0-stable each get a separate ccache.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@veprbl veprbl enabled auto-merge May 7, 2024 02:22
@veprbl veprbl added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 4760015 May 7, 2024
85 of 87 checks passed
@veprbl veprbl deleted the ccache-key-release branch May 7, 2024 03:06
ajentsch pushed a commit that referenced this pull request May 20, 2024
### Briefly, what does this PR introduce?
This PR adds the release environment name to the ccache key to ensure
that eic_xl:nightly and eic_xl:24.04.0-stable each get a separate
ccache.

### What kind of change does this PR introduce?
- [x] Bug fix (issue: failed ccache writes, e.g.
https://github.com/eic/EICrecon/actions/runs/8977682643/job/24656865794?pr=1418#step:27:3,
and slow eic_xl:24.04.0-stable builds)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants