feat: particleSvc to distribute mass by PDG #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
force-pushed
the
particle-service
branch
from
5fc9576 to
d8af15f
Compare
Capybara summary for PR 1487 |
wdconinc
force-pushed
the
particle-service
branch
from
727324f to
86cd35d
Compare
wdconinc
commented
Jun 5, 2024
4 tasks
for more information, see https://pre-commit.ci
wdconinc
force-pushed
the
particle-service
branch
from
7b33546 to
81ff5f3
Compare
veprbl
reviewed
Jun 18, 2024
wdconinc
commented
Jun 18, 2024
wdconinc
commented
Jun 25, 2024
wdconinc
commented
Jun 25, 2024
wdconinc
commented
Jun 25, 2024
…lues) Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
veprbl
approved these changes
Jun 25, 2024
veprbl
added a commit
that referenced
this pull request
Jun 27, 2024
### Briefly, what does this PR introduce? Instead of storing the mass of the proton etc in various classes, this PR adds an algorithms::ParticleSvc that distributes the correct masses and charge etc by PDG number. Note: I was playing around with using the algorithms::ParticleSvc as a thin interface-only, and let a JService read a data file and provide the actual service. But I gave up since it seemed pointless. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Instead of storing the mass of the proton etc in various classes, this PR adds an algorithms::ParticleSvc that distributes the correct masses and charge etc by PDG number.
Note: I was playing around with using the algorithms::ParticleSvc as a thin interface-only, and let a JService read a data file and provide the actual service. But I gave up since it seemed pointless.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.