fix: don't require Acts::{Identification,TGeo} component, but require Json #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capybara summary for PR 1520 |
|
I used this patch extensively over the past few days while testing Acts versions from 31 through 36, and didn't encounter any issues. |
wdconinc
force-pushed
the
cmake-acts-identification-tgeo
branch
from
0778969 to
6f866e5
Compare
|
7 tasks
rahmans1
pushed a commit
that referenced
this pull request
Jul 25, 2024
### Briefly, what does this PR introduce? This adapts our tracking algorithms to any Acts version between v31 and v36 (to be released, so additional refactors may hit the Acts main branch that would need porting). The commits in this branch are topologically ordered with reference to the commit message title, Acts PR number, and version validity. All commits compile individually, but no event-for-event validation has been performed. The support for mulitple versions is done by somewhat extensive use of preprocessor directives based on `Acts_VERSION_MAJOR`. Builds with: - v32.1.0: https://eicweb.phy.anl.gov/containers/eic_container/-/jobs/3481513#L3103 - v33.1.0: https://eicweb.phy.anl.gov/containers/eic_container/-/jobs/3482111#L3549 - v34.1.0: https://eicweb.phy.anl.gov/containers/eic_container/-/jobs/3482134#L3699 - v35.0.0: locally, but not yet in eic_container since this requires #1520 and related eic-spack PRs first ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue: Acts versions are released faster than we can keep up with) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No. --------- Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
We do not use the Acts Identification and TGeo plugins, but we do need the Acts Json plugin.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.