Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImagingTopoCluster: fix Init printouts by adding missing break statements #1533

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

sebouh137
Copy link
Contributor

@sebouh137 sebouh137 commented Jul 22, 2024

Fixed an issue where "break" is not included in a case/break statement.

Briefly, what does this PR introduce?

When initializing the ImagingTopoCluster algorithm, there is a switch statement wherein different things are printed to inform the user what the parameters are (depending on the layer mode). This lacked breaks for the cases, causing the other print statements to be executed. This patch fixes it.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no. no

Does this PR change default behavior?

yes. only prints out the information about the cuts for defining neighbors that is relevent based on the layer mode.

Fixed an issue where "break" is not included in a case/break statement.
@github-actions github-actions bot added the topic: calorimetry relates to calorimetry label Jul 22, 2024
@veprbl veprbl changed the title Update ImagingTopoCluster.h ImagingTopoCluster: fix Init printouts by adding missing break statements Jul 23, 2024
Copy link

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veprbl veprbl added this to the 24.08.0 milestone Jul 28, 2024
@veprbl veprbl marked this pull request as ready for review July 31, 2024 15:36
@veprbl veprbl added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit d653df9 Jul 31, 2024
87 checks passed
@veprbl veprbl deleted the case_break_fixed branch July 31, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: calorimetry relates to calorimetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FHCAL:HcalEndcapPInsertImagingProtoClusters] [error] Unknown layer mode.
2 participants