Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InclusiveKinematicsML: avoid Ort::Env going out of scope #1542

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Aug 1, 2024

Briefly, what does this PR introduce?

Fixes: #1394
Closes: #1393

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

Copy link

sonarqubecloud bot commented Aug 1, 2024

@veprbl veprbl requested review from a team and ruse-traveler and removed request for a team August 1, 2024 17:58
@veprbl veprbl added this to the 24.08.0 milestone Aug 1, 2024
Copy link
Contributor

@ruse-traveler ruse-traveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Glad to see this was a straightforward fix!

@veprbl veprbl added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit 0461de8 Aug 2, 2024
86 of 87 checks passed
@veprbl veprbl deleted the pr/onnx_fix branch August 2, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling ONNX (InclusiveKinematicsML) is unstable
2 participants