Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalorimeterIslandCluster: avoid complaining about missing readouts #1559

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Aug 7, 2024

Briefly, what does this PR introduce?

This fixes a small regression from #1554 pointed out by @wdconinc. Some error messages would appear for detectors that are not using matrices and don't specify "readout" field. This allows the current status quo to continue, but removes the messages.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@github-actions github-actions bot added the topic: calorimetry relates to calorimetry label Aug 7, 2024
@veprbl veprbl requested a review from wdconinc August 7, 2024 07:52
wdconinc
wdconinc previously approved these changes Aug 7, 2024
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Ultimately the reason why we can't guard m_cfg.readout usage behind existing m_cfg.adjacencyMatrix and m_cfg.peakNeighbourhoodMatrix checks is that it would duplicate error handling for empty readout.

Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
Copy link

sonarqubecloud bot commented Aug 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@veprbl veprbl added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit e34c9ed Aug 7, 2024
85 of 87 checks passed
@veprbl veprbl deleted the pr/reduce_splitting_aftermath branch August 7, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: calorimetry relates to calorimetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants